Skip to content

3D attractor plotting#21

Open
noakaplan675 wants to merge 3 commits intomainfrom
3d_vis
Open

3D attractor plotting#21
noakaplan675 wants to merge 3 commits intomainfrom
3d_vis

Conversation

@noakaplan675
Copy link
Collaborator

Takes as input time series as data to plot in 3D attractors.
In visualization.py

@noakaplan675
Copy link
Collaborator Author

I tried to commit again, after fixing the problems found in the tests.

@dtretiak
Copy link
Collaborator

The function looks good overall, nice work! Although visualization functions can be hard to test, you should still add some basic tests into ./tests/utils/test_visualization.py. That file has some examples of how we test some of the other vis functions which you can follow. It's hard to test functionality with plotting functions, but just making sure the function runs with various input combinations should suffice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants